EN-207 Add asset folder codenames #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokornyd
requested changes
Aug 8, 2024
| { | ||
| return itm; | ||
| } | ||
| else if (itm.Folders != null) |
There was a problem hiding this comment.
I would lose this unnecessary else statement and use null coalescing to make it a bit more compact. also, wouldn't folder be more fitting variable name than itm in the foreach? seems slightly more readable, but that's just a nitpick
foreach (var folder in folders)
{
if (folder.Id == folderId)
{
return folder;
}
var nestedFolder = folder.Folders?.GetFolderHierarchyById(folderId);
if (nestedFolder != null) //This is required so you don't stop processing if the root contains many folders (let the above foreach loop continue)
{
return nestedFolder;
}
}There was a problem hiding this comment.
Yeap, looks good, fixed.
| { | ||
| return folder; | ||
| } | ||
| else if (folder.Folders != null) |
matus12
force-pushed
the
EN-207-add-asset-folder-codenames
branch
from
337c067
to
c15bccd
Compare
pokornyd
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding support for asset folder codenames, so assets can be inserted into specific folder, referenced by its codename.
Checklist
How to test
Try getting / adding asset folders with codenames, adding asset to a folder referenced by codename.